Integration test fixes and improvements #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following crossplane-contrib/provider-aws#711 Signed-off-by: Hasan Turken <turkenh@gmail.com>
Details: crossplane-contrib/provider-aws#782 (comment) Signed-off-by: Hasan Turken <turkenh@gmail.com>
turkenh
force-pushed
the
integration-test-improvements
branch
from
ca2ee7a
to
81f47bc
Compare
turkenh
changed the title
Signed-off-by: Hasan Turken <turkenh@gmail.com>
turkenh
force-pushed
the
integration-test-improvements
branch
from
8cdf6c9
to
b0ef561
Compare
Signed-off-by: Hasan Turken <turkenh@gmail.com>
turkenh
force-pushed
the
integration-test-improvements
branch
from
4a3b35d
to
1b5e3c8
Compare
hasheddan
approved these changes
Sep 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR improves our integration testing script (by following this PR)and fixes an issue causing e2e checks to fail.
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
By observing Github actions e2e check status.