Update crossplane-runtime to 0b469fcc77cd

[ulucinar]

Signed-off-by: Alper Rifat Ulucinar ulucinar@users.noreply.github.com

Description of your changes

A recently merged PR that depends on the new managed.ExternalObservation.Diff struct field, which is not yet available on any crossplane-runtime releases has broken the master. After discussing the issue with @muvaf, we have decided to update the crossplane-runtime dependency to the current master HEAD.

I have:

• Read and followed Crossplane's contribution process.
• Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Successfully provisioned CloudFront Distribution & CachePolicy on a branch containing this PR's branch.

[hasheddan]

Just noting that this is a minor version bump for pre-1.0 controller-runtime, so we might want to double check for any breaking changes :)

[ulucinar]

Hi @hasheddan,
That seems to be change coming from controller-runtime (v0.14.0 has controller-runtime v0.8.0 and master depends on v0.9.2). Would it be enough run provider-aws operator and try a MR? How do you generally verify these changes?

[muvaf]

I think most breaking changes at that level are usually compile errors, which we can verify with make reviewable and make build and integration test we have.

[ulucinar]

Gave this PR a try by successfully provisioning/editing/deleting a MR (CloudFront Distribution and CachePolicy).

[ulucinar]

It looks like we cannot use go v1.14.15 with the new controller-runtime version:

github.com/crossplane/provider-aws/apis/acm/v1alpha1 imports
        sigs.k8s.io/controller-runtime/pkg/client tested by
        sigs.k8s.io/controller-runtime/pkg/client.test imports
        sigs.k8s.io/controller-runtime/pkg/envtest imports
        sigs.k8s.io/controller-runtime/pkg/internal/testing/addr imports
        io/fs: package io/fs is not in GOROOT (/opt/go.1.14.15/src/io/fs)

Should we update go version also, or would rolling back of the PR be a better option @hasheddan, @muvaf ?

[hasheddan]

@ulucinar I think bumping go version sounds fine, the primary place it needs to happen is here: https://github.com/crossplane/provider-aws/blob/f8b42a22bf07b9ad4eb0de9e1799ea1754dda29f/.github/workflows/ci.yml#L13

[ulucinar]

@ulucinar I think bumping go version sounds fine, the primary place it needs to happen is here:

https://github.com/crossplane/provider-aws/blob/f8b42a22bf07b9ad4eb0de9e1799ea1754dda29f/.github/workflows/ci.yml#L13

Thanks @hasheddan!

[alecrajeev]

Sorry about this. I will make it more clear when I have a change that is dependent on crossplane-runtime being updated going forward.

[ulucinar]

@alecrajeev no problem at all. Let's get this merged.

[ulucinar]

@hasheddan, is it possible to retry the e2e-tests job only? I did not see an option on GitHub UI to retrigger job.

I think currently it is not possible:
https://git.luolix.topmunity/t/ability-to-rerun-just-a-single-job-in-a-workflow/17234

I was suspecting I was missing the necessary privileges :)

[ulucinar]

e2e tests are failing on my workstation also with similar symptoms:

 make e2e
17:49:01 [ .. ] installing kind v0.9.0
17:49:02 [ OK ] installing kind v0.9.0
17:49:02 [ .. ] installing kubectl v1.17.11
17:49:02 [ OK ] installing kubectl v1.17.11
17:49:02 [ .. ] installing helm3 v2.16.7
17:49:03 [ OK ] installing helm3 v2.16.7
17:49:03 [ .. ] running integration tests using kind v0.9.0

>>>>>>> setting up local package cache
created cache dir at /home/alper/data/workspaces/github.com/ulucinar/crossplane/provider-aws/.work/inttest-package-cache

>>>>>>> creating k8s cluster using kind
Creating cluster "build-81fe2fd6-inttests" ...
 ✓ Ensuring node image (kindest/node:v1.19.1) 🖼
 ✓ Preparing nodes 📦
 ✓ Writing configuration 📜
 ✓ Starting control-plane 🕹️
 ✓ Installing CNI 🔌
 ✓ Installing StorageClass 💾
 ✗ Waiting ≤ 5m0s for control-plane = Ready ⏳
 • WARNING: Timed out waiting for Ready ⚠️
Set kubectl context to "kind-build-81fe2fd6-inttests"
You can now use your cluster with:

kubectl cluster-info --context kind-build-81fe2fd6-inttests

Thanks for using kind! 😊
Image: "crossplane/provider-aws-controller:v0.18.0-rc.0.194.g840601a4" with ID "sha256:fa7ec785e5431380e4141315ff346e9455bcd31759dc62c00f64f81f547ee205" not yet present on node "build-81fe2fd6-inttests-control-plane", loading...

>>>>>>> pre-cache package by copying to kind node

>>>>>>> create crossplane-system namespace
namespace/crossplane-system created

>>>>>>> create persistent volume and claim for mounting package-cache
persistentvolume/package-cache created
persistentvolumeclaim/package-cache created

>>>>>>> installing crossplane from master channel
"crossplane-master" has been added to your repositories

using crossplane version 1.4.0-rc.0.54.g8e76b9cd
Error: timed out waiting for the condition

>>>>>>> Cleaning up...
Deleting cluster "build-81fe2fd6-inttests" ...
18:00:19 [FAIL]
make[1]: *** [Makefile:92: test-integration] Error 1
make: *** [build/makelib/common.mk:377: e2e] Error 2```

This seemed to be related to kind on my workstation. Could be a similar issue with the e2e-tests job. 

[ulucinar]

Will try with a new kind image...

[hasheddan]

@ulucinar this looks like latest Crossplane is failing to install might be worth doing a watch on the pods while tests are running.. if you run make e2e.run skipcleanup=true the cluster will stick around after the tests fail

[ulucinar]

@ulucinar this looks like latest Crossplane is failing to install might be worth doing a watch on the pods while tests are running.. if you run make e2e.run skipcleanup=true the cluster will stick around after the tests fail

Hi @hasheddan,
It turns out that we have hit this issue, which is related to a recent kernel change.

I had observed a similar issue when preparing a demo cluster for the hack week. As indicated here, I have retried with a new kind version and node image and it seems to be working.

Thank you very much for your help!