Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Specification of the CRD API Version a Controller Watches & Reconciles #400

Merged
merged 6 commits into from
May 14, 2024
Merged

Allow Specification of the CRD API Version a Controller Watches & Reconciles #400

merged 6 commits into from
May 14, 2024

Commits on May 9, 2024

  1. Add config.Resource.ControllerReconcileVersion to be able to control … 

    …the specific CR API version

the associated controller will watch & reconcile.

- For backwards-compatibility, ControllerReconcileVersion defaults to Version if unspecified.

Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
    @ulucinar
    ulucinar committed May 9, 2024
    Configuration menu
    Copy the full SHA
    cc7324e View commit details
    Browse the repository at this point in the history

  2. Rename conversion.Mode to conversion.ListConversionMode 

    Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
    @ulucinar
    ulucinar committed May 9, 2024
    Configuration menu
    Copy the full SHA
    f5b0d82 View commit details
    Browse the repository at this point in the history

  3. Add config.TerraformConversion to abstract the runtime parameter conv… 

    …ersions between

the Crossplane & Terraform layers.

Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
    @ulucinar
    ulucinar committed May 9, 2024
    Configuration menu
    Copy the full SHA
    83b3b8e View commit details
    Browse the repository at this point in the history

  4. conversion.singletonListConverter now operates on a configured set of… 

    … path prefixes

- Previously, it only converted parameters under spec.forProvider
- This missed CRD API conversions (of singleton lists) under
  spec.initProvider & status.atProvider

Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
(cherry picked from commit 08b3f3260ce86457271dda7401dfd9a69a10f656)
    @ulucinar
    ulucinar committed May 9, 2024
    Configuration menu
    Copy the full SHA
    b5dbcc5 View commit details
    Browse the repository at this point in the history

  5. Add config.NewTFSingletonConversion that returns a new TerraformConve… 

    …rsion to convert between

singleton lists and embedded objects when parameters pass Crossplane and Terraform boundaries.

Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
    @ulucinar
    ulucinar committed May 9, 2024
    Configuration menu
    Copy the full SHA
    c606b4c View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Deprecate config.Reference.Type in favor of config.Reference.Terrafor… 

    …mName

- TerraformName will automatically handle name & version configurations that will affect
  the generated cross-resource reference. This is crucial especially if the
  provider generates multiple versions for its MR APIs.

Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
    @ulucinar
    ulucinar committed May 10, 2024
    Configuration menu
    Copy the full SHA
    9463489 View commit details
    Browse the repository at this point in the history