Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve references docs #413

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: improve references docs #413

wants to merge 1 commit into from

Conversation

yordis
Copy link
Contributor

@yordis yordis commented Jun 1, 2024 •
edited
Loading

Description of your changes

Adding some examples about the key, I couldn't figure out that the key could be a path to a field.

I have:

  • Read and followed Upjet's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

  • No production code affected, only docs

@yordis
chore: improve references docs
d37f2e3 
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
mergenci
mergenci approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@mergenci mergenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yordis. I value documentation updates highly 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mergenci mergenci mergenci approved these changes

@haarchri haarchri haarchri approved these changes

@ulucinar ulucinar Awaiting requested review from ulucinar ulucinar is a code owner

@sergenyalcin sergenyalcin Awaiting requested review from sergenyalcin sergenyalcin is a code owner

@erhancagirici erhancagirici Awaiting requested review from erhancagirici erhancagirici is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yordis @mergenci @haarchri