Add birthday and gender to IProfile #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related https://github.com/react-native-seoul/react-native-kakao-login/pull/102/files
getProfile 붙이다보니, IProfile에 birthday와 gender 없는걸 발견해서 요 부분 추가한것입니다.
gender 같은 경우 리터럴로 타입을 선언할까 하다가.. 카카오 공식 문서랑 넘겨온 값이 달라서 걍
string으로 했습니다.https://developers.kakao.com/docs/latest/ko/user-mgmt/common#gender
여기선 소문자로 male/female 이라고 적혀있지만
제가 받은 값은 MALE 이었거든요.