-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: extract logic by platforms using interface #345
Conversation
시간내서 PR만들어주셔서 감사합니다! 바빠서 이슈만 만들어놓고 제가 고칠생각을 못했네요🥲
|
리뷰해주셔서 감사합니다 :) re-exports 는 놓친 부분이었는데 감사합니다. module suffixes 를 설정해보았는데요! 설정된 순서대로 컴파일 시점에 파일참조 우선순위를 정하는 옵션이다보니 |
@@ -2,7 +2,7 @@ | |||
"name": "@react-native-seoul/kakao-login", | |||
"version": "5.2.4", | |||
"description": "React Native Module for Kakao Login", | |||
"main": "src/index.js", | |||
"main": "src/index", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR 좋아보입니다. 감사합니다 🙏
may resolve #337