Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build error with use-dev-tty #886

Closed
gwenn opened this issue May 5, 2024 · 5 comments
Closed

Build error with use-dev-tty #886

gwenn opened this issue May 5, 2024 · 5 comments

Comments

@gwenn
Copy link
Contributor

gwenn commented May 5, 2024

Describe the bug
Build fails with use-dev-tty feature

To Reproduce

% cargo check --no-default-features --features "use-dev-tty events"
...
error[E0061]: this method takes 1 argument but 2 arguments were supplied
  --> src/event/source/unix/tty.rs:83:18
   |
83 |         match fd.read(buf, buf.len()) {
   |                  ^^^^    -----------
   |                          | |
   |                          | unexpected argument of type `usize`
   |                          help: remove the extra argument
   |
note: method defined here
  --> src/terminal/sys/file_descriptor.rs:32:12
   |
32 |     pub fn read(&self, buffer: &mut [u8]) -> io::Result<usize> {
   |            ^^^^        -----------------

It seems to be related to #821

Expected behavior
The build should succeed.
And ideally, use-dev-tty should imply events but without mio dependencies.

OS

  • MacOs
@joshka
Copy link
Collaborator

joshka commented May 5, 2024

Fixed in #888

@gwenn gwenn closed this as completed May 6, 2024
@gwenn
Copy link
Contributor Author

gwenn commented May 6, 2024

Only partially fixed:

And ideally, use-dev-tty should imply events but without mio dependencies.

@joshka
Copy link
Collaborator

joshka commented May 6, 2024

Only partially fixed:

And ideally, use-dev-tty should imply events but without mio dependencies.

Can you expand on this?

@gwenn
Copy link
Contributor Author

gwenn commented May 7, 2024

  • use-dev-tty is useless without events
  • but events implies mio while mio dependencies are useless with use-dev-tty

@joshka
Copy link
Collaborator

joshka commented May 7, 2024

Got it - makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants