Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test use-dev-tty feature #887

Closed
wants to merge 1 commit into from
Closed

Test use-dev-tty feature #887

wants to merge 1 commit into from

Conversation

gwenn
Copy link
Contributor

@gwenn gwenn commented May 5, 2024

Build should failed until #886 is fixed.

@gwenn gwenn requested a review from TimonPost as a code owner May 5, 2024 06:35
joshka
joshka approved these changes May 5, 2024
View reviewed changes
Copy link
Collaborator

@joshka joshka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshka
Copy link
Collaborator

joshka commented May 5, 2024

I cherry-picked this into #888 to ensure that the combination of fixes tested this correctly.
I suspect that if the merge is squashed, then you'll lose the credit for this, but I wanted to make sure that all the build breaking issues were fixed at once, so I hope this is ok with you.

@joshka joshka mentioned this pull request May 5, 2024
Merged
@gwenn
Copy link
Contributor Author

gwenn commented May 5, 2024

@joshka Thanks.

@gwenn gwenn closed this May 5, 2024
@gwenn gwenn deleted the test_use_dev_tty branch May 5, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshka joshka joshka approved these changes

@TimonPost TimonPost Awaiting requested review from TimonPost TimonPost is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gwenn @joshka