Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with webkit2gtk 4.1 and libsoup3 #1139

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Build with webkit2gtk 4.1 and libsoup3 #1139

merged 1 commit into from
Jan 23, 2024

Conversation

bgermann
Copy link
Contributor

Forwarded from Debian:

Debian's webkit2gtk maintainers intend to stop building the 4.0 API soon. The 4.1 API is the same as the 4.0 API except that it uses libsoup3 instead of libsoup2.4.

Fedora has already stopped building the 4.0 API in preparation for the Fedora 40 release in a few months.

libsoup2 -> libsoup3 porting is sometimes complex. But in this case, I only made a minimal change and I was able to download a Bible translation with Xiphos and things appeared to work ok.

@karlkleinpaste karlkleinpaste merged commit d5a0650 into crosswire:master Jan 23, 2024
1 of 7 checks passed
@karlkleinpaste
Copy link
Contributor

@bgermann
observation after the fact:
building on f39, using -DGTKHTML=TRUE because we're (still) on the old editor, build succeeded but run crashed because both soup2 and soup3 were dyn.linked, causing soup3 to abort. turns out that using 4.0 in this circumstance was still the problem -- 4.0 requires soup2, 4.1 requires soup3. is there any reason why changing to 4.1 in this stanza would not also be correct?

  if (NOT WEBKIT1 AND GTKHTML)
    # Gtk+-3.0 + Webkit2 + WebKit-editor
    pkg_check_modules(Gtk REQUIRED IMPORTED_TARGET
      "gtk+-3.0"
      "webkit2gtk-4.1"
      "gtkhtml-editor-4.0"
      "libgtkhtml-4.0"
      )
  endif()

@bgermann
Copy link
Contributor Author

bgermann commented Feb 1, 2024

As far as I can see this stanza will also need the update. I guess the patch submitter just tested with the Debian configuration and therefore only changed the relevant path for that.

@karlkleinpaste
Copy link
Contributor

thx. i'll take care of it.

karlkleinpaste added a commit that referenced this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants