Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: source downloading when source and dest have different base name #608

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

yzerk
Copy link
Contributor

@yzerk yzerk commented Jun 27, 2023

No description provided.

@yzerk yzerk requested a review from andrii-bodnar June 27, 2023 09:02
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #608 (cb6e997) into cli3 (c4ad0af) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               cli3     #608      +/-   ##
============================================
+ Coverage     61.76%   61.78%   +0.02%     
- Complexity     1189     1191       +2     
============================================
  Files           180      180              
  Lines          5188     5188              
  Branches        787      787              
============================================
+ Hits           3204     3205       +1     
  Misses         1552     1552              
+ Partials        432      431       -1     
Impacted Files Coverage Δ
...in/cli/commands/actions/DownloadSourcesAction.java 49.70% <0.00%> (ø)

... and 1 file with indirect coverage changes

@andrii-bodnar andrii-bodnar merged commit 60a760a into cli3 Jun 27, 2023
8 checks passed
@andrii-bodnar andrii-bodnar deleted the fix/#342-source-download-for-diff-dest branch June 27, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.11 broke source downloading when source and dest have different base name
2 participants