Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support of passing labels to pre translate command #649

Merged

Conversation

debanjanc01
Copy link
Contributor

This closes #640

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #649 (7e51d80) into main (201eb58) will decrease coverage by 0.19%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main     #649      +/-   ##
============================================
- Coverage     62.58%   62.39%   -0.19%     
  Complexity     1322     1322              
============================================
  Files           200      200              
  Lines          5563     5580      +17     
  Branches        841      841              
============================================
  Hits           3481     3481              
- Misses         1633     1650      +17     
  Partials        449      449              
Files Coverage Δ
...a/com/crowdin/cli/commands/actions/CliActions.java 69.24% <ø> (ø)
...n/cli/commands/picocli/PreTranslateSubcommand.java 28.00% <ø> (ø)
...din/cli/commands/functionality/RequestBuilder.java 54.27% <0.00%> (-0.33%) ⬇️
...owdin/cli/commands/actions/PreTranslateAction.java 0.00% <0.00%> (ø)

@andrii-bodnar andrii-bodnar added the hacktoberfest This issue welcomes contributions for Hacktoberfest label Oct 5, 2023
@andrii-bodnar andrii-bodnar added enhancement new option New option for an existing command labels Oct 5, 2023
Co-authored-by: Andrii Bodnar <andrii.bodnar@crowdin.com>
@debanjanc01
Copy link
Contributor Author

Hi @andrii-bodnar shall I squash all the commits into a single one?

@andrii-bodnar
Copy link
Member

No, it's not needed, I will squash them during the merge

@debanjanc01
Copy link
Contributor Author

@andrii-bodnar alright, thanks!

Copy link
Member

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@debanjanc01 thanks a lot for the contribution! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement hacktoberfest This issue welcomes contributions for Hacktoberfest hacktoberfest-accepted new option New option for an existing command
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the '--label' parameter to the 'pre-translate' command
2 participants