lint: replace type assertions and type switch on errors (#3376)

* errorlint: replace type assertions on errors
* errorlint: replace type switch on errors
* lint

.golangci.yml

@@ -118,7 +118,7 @@ linters-settings:
         arguments: [6]
       - name: function-length
         # lower this after refactoring
-        arguments: [110, 237]
+        arguments: [111, 238]
       - name: get-return
         disabled: true
       - name: increment-decrement
@@ -333,14 +333,6 @@ issues:
         - errorlint
       text: "non-wrapping format verb for fmt.Errorf. Use `%w` to format errors"
 
-    - linters:
-        - errorlint
-      text: "type assertion on error will fail on wrapped errors. Use errors.As to check for specific errors"
-
-    - linters:
-        - errorlint
-      text: "type switch on error will fail on wrapped errors. Use errors.As to check for specific errors"
-
     - linters:
         - nosprintfhostport
       text: "host:port in url should be constructed with net.JoinHostPort and not directly with fmt.Sprintf"

cmd/crowdsec/win_service.go

@@ -67,7 +67,7 @@ func runService(name string) error {
 	// All the calls to logging before the logger is configured are pretty much useless, but we keep them for clarity
 	err := eventlog.InstallAsEventCreate("CrowdSec", eventlog.Error|eventlog.Warning|eventlog.Info)
 	if err != nil {
-		if errno, ok := err.(syscall.Errno); ok {
+		if errno, ok := err.(syscall.Errno); ok {   //nolint:errorlint
 			if errno == windows.ERROR_ACCESS_DENIED {
 				log.Warnf("Access denied when installing event source, running as non-admin ?")
 			} else {

pkg/acquisition/acquisition.go

@@ -328,7 +328,8 @@ func GetMetrics(sources []DataSource, aggregated bool) error {
 
 		for _, metric := range metrics {
 			if err := prometheus.Register(metric); err != nil {
-				if _, ok := err.(prometheus.AlreadyRegisteredError); !ok {
+				var alreadyRegisteredErr prometheus.AlreadyRegisteredError
+				if !errors.As(err, &alreadyRegisteredErr) {
 					return fmt.Errorf("could not register metrics for datasource %s: %w", sources[i].GetName(), err)
 				}
 				// ignore the error