Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce log verbosity at startup #2363

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Reduce log verbosity at startup #2363

merged 1 commit into from
Jul 19, 2023

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jul 19, 2023

A configuration syntax test is performed every time the service is started from systemd. The resulting error, if any, is shown on journalctl logs.
This PR removes the unnecessary output in crowdsec.log generated by the configuration test.

A configuration syntax test is performed every time the service is
started from systemd. The resulting error, if any, is shown on
journalctl logs.
This PR removes the unnecessary output in crowdsec.log generated by the
configuration test.
@mmetc mmetc added the kind/enhancement New feature or request label Jul 19, 2023
@mmetc mmetc added this to the 1.5.3 milestone Jul 19, 2023
@github-actions
Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #2363 (bfaf306) into master (bb16552) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2363      +/-   ##
==========================================
- Coverage   56.23%   56.21%   -0.03%     
==========================================
  Files         182      186       +4     
  Lines       25379    25762     +383     
==========================================
+ Hits        14273    14481     +208     
- Misses       9582     9725     +143     
- Partials     1524     1556      +32     
Flag Coverage Δ
bats 37.64% <0.00%> (-0.14%) ⬇️
unit-linux 54.76% <ø> (-0.07%) ⬇️
unit-windows 51.39% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/crowdsec/serve.go 59.28% <0.00%> (+1.42%) ⬆️

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@LaurenceJJones LaurenceJJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit 3c16139 into master Jul 19, 2023
14 checks passed
@mmetc mmetc deleted the configtest branch July 19, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants