Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force rfc 3339 date format in metrics push #2402

Merged
merged 3 commits into from
Nov 28, 2023
Merged

Conversation

blotus
Copy link
Member

@blotus blotus commented Aug 2, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

@blotus: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

@blotus: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@blotus
Copy link
Member Author

blotus commented Aug 2, 2023

/kind fix

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (15542b7) 58.24% compared to head (3840224) 58.16%.
Report is 2 commits behind head on master.

Files Patch % Lines
pkg/apiserver/apic_metrics.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2402      +/-   ##
==========================================
- Coverage   58.24%   58.16%   -0.08%     
==========================================
  Files         199      199              
  Lines       26847    26925      +78     
==========================================
+ Hits        15636    15660      +24     
- Misses       9670     9721      +51     
- Partials     1541     1544       +3     
Flag Coverage Δ
bats 38.23% <60.00%> (-0.04%) ⬇️
unit-linux 55.41% <80.00%> (-0.03%) ⬇️
unit-windows 51.75% <80.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LaurenceJJones
Copy link
Contributor

Be careful the windows test are failing for real as the strings do not match should fix them

@LaurenceJJones LaurenceJJones added this to the 1.5.6 milestone Oct 24, 2023
@blotus blotus merged commit 380cbf7 into master Nov 28, 2023
13 checks passed
@blotus blotus deleted the metrics-date-format branch November 28, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants