[whitelist] metrics improvement

[LaurenceJJones]

Fix #2462
Based on #2422

We split out whitelist metrics from parsers, and provide detail breakdown of each expression.

Mostly looking for feedback as I know on the metrics side, we still need to merge the above before moving forward with this one.

Example of metrics;

Whitelist Metrics:
╭───────────────────────────────────────────┬────┬──────╮
│                 Whitelist                 │ WL │ NoWL │
├───────────────────────────────────────────┼────┼──────┤
│ crowdsecurity/jellyfin-whitelist:[0]      │ -  │ 4    │
│ crowdsecurity/nextcloud-whitelist:[0]     │ 4  │ -    │
│ crowdsecurity/whitelists:[10.0.0.0/8]     │ -  │ 4    │
│ crowdsecurity/whitelists:[127.0.0.1]      │ -  │ 4    │
│ crowdsecurity/whitelists:[172.16.0.0/12]  │ -  │ 4    │
│ crowdsecurity/whitelists:[192.168.0.0/16] │ -  │ 4    │
│ crowdsecurity/whitelists:[::1]            │ -  │ 4    │
╰───────────────────────────────────────────┴────┴──────╯

Currently I am using the actual index but for users we may just want to increase the digit +1 so they know if was the first expression that passed for example.

[github-actions]

@LaurenceJJones: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

• /kind feature
• /kind enhancement
• /kind fix
• /kind chore
• /kind dependencies

Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

[github-actions]

@LaurenceJJones: There are no area labels on this PR. You can add as many areas as you see fit.

• /area agent
• /area local-api
• /area cscli
• /area security
• /area configuration

Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

[codecov]

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (272cf54) 57.16% compared to head (94de6de) 56.97%.
Report is 63 commits behind head on master.

Files	Patch %	Lines
cmd/crowdsec-cli/metrics.go	18.75%	13 Missing ⚠️
cmd/crowdsec-cli/metrics_table.go	50.00%	4 Missing and 2 partials ⚠️
pkg/parser/node_metrics.go	77.77%	4 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2517      +/-   ##
==========================================
- Coverage   57.16%   56.97%   -0.20%     
==========================================
  Files         190      187       -3     
  Lines       26156    25845     -311     
==========================================
- Hits        14953    14726     -227     
+ Misses       9633     9573      -60     
+ Partials     1570     1546      -24     

Flag	Coverage Δ
bats	38.78% <42.85%> (-0.10%)	⬇️
unit-linux	55.18% <87.50%> (+0.01%)	⬆️
unit-windows	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[LaurenceJJones]

/kind enhancement
/area agent

[mmetc]

Hi @LaurenceJJones what's the state on this?
Still aimed at 1.5.6? Can I help address the conflicts?
I ask because I'd like to refact and address #2618

[LaurenceJJones]

Closed in favor of #2813