Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove PAPI feature flag #2601

Merged
merged 6 commits into from
Dec 8, 2023
Merged

remove PAPI feature flag #2601

merged 6 commits into from
Dec 8, 2023

Conversation

blotus
Copy link
Member

@blotus blotus commented Nov 17, 2023

No description provided.

@blotus blotus marked this pull request as draft November 17, 2023 16:13
Copy link

@blotus: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@blotus: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@blotus
Copy link
Member Author

blotus commented Nov 17, 2023

/kind feature
/area local-api

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 44 lines in your changes are missing coverage. Please review.

Comparison is base (84cbff1) 54.92% compared to head (dae9a61) 54.92%.
Report is 1 commits behind head on master.

Files Patch % Lines
pkg/apiserver/apiserver.go 7.69% 23 Missing and 1 partial ⚠️
pkg/longpollclient/client.go 0.00% 19 Missing ⚠️
pkg/csconfig/console.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2601      +/-   ##
==========================================
- Coverage   54.92%   54.92%   -0.01%     
==========================================
  Files         224      224              
  Lines       29784    29779       -5     
==========================================
- Hits        16359    16355       -4     
+ Misses      11834    11832       -2     
- Partials     1591     1592       +1     
Flag Coverage Δ
bats 36.33% <13.72%> (-0.01%) ⬇️
unit-linux 49.64% <0.00%> (-0.01%) ⬇️
unit-windows 47.77% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buixor buixor added this to the 1.5.6 milestone Dec 8, 2023
@blotus blotus marked this pull request as ready for review December 8, 2023 10:27
@blotus blotus merged commit 04f3dc0 into master Dec 8, 2023
13 checks passed
@blotus blotus deleted the papi-ga branch December 8, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants