Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: avoid pipe in makefile, correctly report error in CI when tests fail #2621

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Nov 28, 2023

so we don't assume bash+pipefail for the makefile

so we don't assume bash+pipefail for the makefile
@mmetc mmetc requested a review from blotus November 28, 2023 15:33
Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (380cbf7) 58.14% compared to head (1896da8) 58.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2621      +/-   ##
==========================================
+ Coverage   58.14%   58.18%   +0.03%     
==========================================
  Files         199      199              
  Lines       26925    26925              
==========================================
+ Hits        15656    15665       +9     
+ Misses       9725     9719       -6     
+ Partials     1544     1541       -3     
Flag Coverage Δ
bats 38.28% <ø> (+0.05%) ⬆️
unit-linux 55.47% <ø> (+0.03%) ⬆️
unit-windows 51.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc merged commit 1aa4fc5 into master Nov 28, 2023
16 checks passed
@mmetc mmetc deleted the ci-pipefail branch November 28, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants