Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cscli context detect: fix nil dereference #2635

Merged
merged 5 commits into from
Dec 5, 2023
Merged

cscli context detect: fix nil dereference #2635

merged 5 commits into from
Dec 5, 2023

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Dec 4, 2023

Also remove the log.warnings, which were not shown because log level was set to Error

Copy link

github-actions bot commented Dec 4, 2023

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

github-actions bot commented Dec 4, 2023

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master@8bb7da3). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2635   +/-   ##
=========================================
  Coverage          ?   51.54%           
=========================================
  Files             ?      117           
  Lines             ?    15319           
  Branches          ?        0           
=========================================
  Hits              ?     7896           
  Misses            ?     6560           
  Partials          ?      863           
Flag Coverage Δ
unit-windows 51.54% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc merged commit 486f96e into master Dec 5, 2023
13 checks passed
@mmetc mmetc deleted the lapi-detect-nil branch December 5, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants