Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/dumps.DumpTree: split to reduce complexity #3001

Merged
merged 2 commits into from
May 31, 2024
Merged

pkg/dumps.DumpTree: split to reduce complexity #3001

merged 2 commits into from
May 31, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented May 13, 2024

No description provided.

@mmetc mmetc added this to the 1.6.3 milestone May 13, 2024
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 52.37%. Comparing base (b8ee31a) to head (b0ced8e).
Report is 1 commits behind head on master.

Files Patch % Lines
pkg/dumps/parser_dump.go 85.71% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3001      +/-   ##
==========================================
- Coverage   52.37%   52.37%   -0.01%     
==========================================
  Files         280      280              
  Lines       35422    35431       +9     
==========================================
+ Hits        18554    18557       +3     
- Misses      15027    15032       +5     
- Partials     1841     1842       +1     
Flag Coverage Δ
bats 40.09% <90.00%> (+0.03%) ⬆️
unit-linux 34.84% <0.00%> (-0.03%) ⬇️
unit-windows 30.97% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit 599a5a4 into master May 31, 2024
17 checks passed
@mmetc mmetc deleted the lint-cyclo branch May 31, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants