Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db: don't set bouncer last_pull until first connection #3020

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented May 17, 2024

No description provided.

Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@codecov-commenter
Copy link

codecov-commenter commented May 17, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 13 lines in your changes missing coverage. Please review.

Project coverage is 52.53%. Comparing base (bd4540b) to head (f3518c3).

Files Patch % Lines
cmd/crowdsec-cli/bouncers.go 33.33% 2 Missing and 2 partials ⚠️
cmd/crowdsec-cli/bouncers_table.go 40.00% 2 Missing and 1 partial ⚠️
pkg/database/decisions.go 66.66% 3 Missing ⚠️
pkg/apiserver/controllers/v1/decisions.go 71.42% 2 Missing ⚠️
pkg/database/bouncers.go 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3020      +/-   ##
==========================================
+ Coverage   52.49%   52.53%   +0.03%     
==========================================
  Files         281      281              
  Lines       35435    35457      +22     
==========================================
+ Hits        18602    18627      +25     
+ Misses      15011    15005       -6     
- Partials     1822     1825       +3     
Flag Coverage Δ
bats 40.31% <81.25%> (+0.03%) ⬆️
unit-linux 34.82% <6.66%> (+<0.01%) ⬆️
unit-windows 30.94% <5.12%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc added this to the 1.6.3 milestone May 17, 2024
@mmetc mmetc force-pushed the nil-bouncer-lastpull branch 3 times, most recently from e57b79b to d7d7d46 Compare May 31, 2024 21:45
@mmetc mmetc marked this pull request as draft May 31, 2024 21:45
@mmetc mmetc force-pushed the nil-bouncer-lastpull branch 2 times, most recently from 6d02793 to acee382 Compare June 4, 2024 14:39
@mmetc mmetc marked this pull request as ready for review June 4, 2024 14:41
@mmetc mmetc merged commit 44a2014 into master Jun 17, 2024
17 checks passed
@mmetc mmetc deleted the nil-bouncer-lastpull branch June 17, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants