Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db: force decisions to have an expiration timestamp #3021

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented May 17, 2024

No description provided.

Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc added the kind/fix label May 17, 2024
@mmetc mmetc added this to the 1.6.3 milestone May 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 17, 2024

Codecov Report

Attention: Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 39.21%. Comparing base (40021b6) to head (18cb43f).

Files with missing lines Patch % Lines
pkg/database/ent/decision_create.go 25.00% 2 Missing and 1 partial ⚠️
pkg/database/ent/decision.go 33.33% 2 Missing ⚠️
pkg/apiserver/apic.go 0.00% 1 Missing ⚠️
pkg/database/ent/mutation.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3021      +/-   ##
==========================================
- Coverage   39.21%   39.21%   -0.01%     
==========================================
  Files         480      480              
  Lines       62058    62024      -34     
==========================================
- Hits        24337    24323      -14     
+ Misses      35076    35056      -20     
  Partials     2645     2645              
Flag Coverage Δ
bats 31.39% <33.33%> (-0.02%) ⬇️
unit-linux 34.72% <0.00%> (-0.02%) ⬇️
unit-windows 24.65% <30.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc force-pushed the nil-decision-until branch 2 times, most recently from ff6ba35 to 67f7412 Compare May 31, 2024 20:41
@mmetc mmetc force-pushed the nil-decision-until branch 2 times, most recently from 67cca11 to de67edc Compare June 12, 2024 06:12
@mmetc mmetc requested a review from blotus June 12, 2024 08:13
@mmetc mmetc removed this from the 1.6.3 milestone Jun 21, 2024
@mmetc mmetc added this to the 1.6.4 milestone Jul 24, 2024
@mmetc mmetc modified the milestones: 1.6.4, 1.6.5 Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants