Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor pkg/database, pkg/models #3022

Merged
merged 5 commits into from
Jun 5, 2024
Merged

refactor pkg/database, pkg/models #3022

merged 5 commits into from
Jun 5, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented May 17, 2024

No description provided.

@mmetc mmetc added this to the 1.6.3 milestone May 17, 2024
Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc force-pushed the pkg-models-helpers branch 2 times, most recently from 79a8675 to a781294 Compare May 17, 2024 15:24
@codecov-commenter
Copy link

codecov-commenter commented May 17, 2024

Codecov Report

Attention: Patch coverage is 76.11940% with 16 lines in your changes missing coverage. Please review.

Project coverage is 52.43%. Comparing base (73e03ef) to head (3848c80).

Files Patch % Lines
pkg/models/helpers.go 76.19% 11 Missing and 4 partials ⚠️
pkg/database/alerts.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3022      +/-   ##
==========================================
+ Coverage   52.41%   52.43%   +0.02%     
==========================================
  Files         280      280              
  Lines       35460    35442      -18     
==========================================
- Hits        18585    18583       -2     
+ Misses      15042    15029      -13     
+ Partials     1833     1830       -3     
Flag Coverage Δ
bats 40.15% <69.23%> (+<0.01%) ⬆️
unit-linux 34.83% <0.00%> (ø)
unit-windows 30.95% <64.17%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc force-pushed the pkg-models-helpers branch 2 times, most recently from ea37691 to 91c824e Compare May 31, 2024 10:00
@mmetc mmetc marked this pull request as ready for review May 31, 2024 10:03
@mmetc mmetc force-pushed the pkg-models-helpers branch 2 times, most recently from 72b8473 to 42436ae Compare June 3, 2024 13:55
Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit 9e859c0 into master Jun 5, 2024
17 checks passed
@mmetc mmetc deleted the pkg-models-helpers branch June 5, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants