Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor "cscli decisions" #3061

Merged
merged 8 commits into from
Jun 6, 2024
Merged

refactor "cscli decisions" #3061

merged 8 commits into from
Jun 6, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jun 5, 2024

No description provided.

@mmetc mmetc added this to the 1.6.3 milestone Jun 5, 2024
Copy link

github-actions bot commented Jun 5, 2024

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

github-actions bot commented Jun 5, 2024

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc requested a review from sabban June 5, 2024 13:36
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 71.68142% with 64 lines in your changes missing coverage. Please review.

Project coverage is 52.43%. Comparing base (9e859c0) to head (9753403).

Files Patch % Lines
cmd/crowdsec-cli/decisions.go 75.75% 36 Missing and 4 partials ⚠️
cmd/crowdsec-cli/alerts.go 55.76% 19 Missing and 4 partials ⚠️
cmd/crowdsec-cli/lapi.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3061   +/-   ##
=======================================
  Coverage   52.43%   52.43%           
=======================================
  Files         280      280           
  Lines       35442    35452   +10     
=======================================
+ Hits        18584    18591    +7     
- Misses      15027    15030    +3     
  Partials     1831     1831           
Flag Coverage Δ
bats 40.18% <86.17%> (+0.05%) ⬆️
unit-linux 34.82% <0.00%> (+<0.01%) ⬆️
unit-windows 30.96% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit 114a966 into master Jun 6, 2024
17 checks passed
@mmetc mmetc deleted the cscli-decisions branch June 6, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants