Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable linter: revive (indent-error-flow) #3068

Merged
merged 3 commits into from
Jun 10, 2024
Merged

enable linter: revive (indent-error-flow) #3068

merged 3 commits into from
Jun 10, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jun 7, 2024

No description provided.

@mmetc mmetc added this to the 1.6.3 milestone Jun 7, 2024
Copy link

github-actions bot commented Jun 7, 2024

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 29 lines in your changes missing coverage. Please review.

Project coverage is 34.10%. Comparing base (7fd01ae) to head (65a8d31).

Files Patch % Lines
...on/modules/loki/internal/lokiclient/loki_client.go 0.00% 10 Missing ⚠️
pkg/acquisition/modules/kinesis/kinesis.go 50.00% 5 Missing ⚠️
pkg/acquisition/modules/s3/s3.go 54.54% 5 Missing ⚠️
pkg/types/event.go 0.00% 4 Missing ⚠️
pkg/leakybucket/reset_filter.go 81.25% 2 Missing and 1 partial ⚠️
pkg/acquisition/modules/appsec/rx_operator.go 0.00% 1 Missing ⚠️
pkg/hubtest/hubtest_item.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3068       +/-   ##
===========================================
- Coverage   49.14%   34.10%   -15.04%     
===========================================
  Files         281      280        -1     
  Lines       35429    35421        -8     
===========================================
- Hits        17410    12080     -5330     
- Misses      16288    22040     +5752     
+ Partials     1731     1301      -430     
Flag Coverage Δ
bats ?
unit-linux 34.82% <46.29%> (?)
unit-windows 30.96% <41.37%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LaurenceJJones LaurenceJJones self-requested a review June 10, 2024 13:46
Copy link
Contributor

@LaurenceJJones LaurenceJJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, left a single comment its not a game changer just qol

@mmetc mmetc merged commit 31ed9fb into master Jun 10, 2024
17 checks passed
@mmetc mmetc deleted the indent-error-flow branch June 10, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants