Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cscli: refactor hubtests / extract methods run(), coverage() #3086

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jun 13, 2024

No description provided.

@mmetc mmetc added this to the 1.6.3 milestone Jun 13, 2024
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 7.80142% with 130 lines in your changes missing coverage. Please review.

Project coverage is 52.55%. Comparing base (4e09ae2) to head (dce0528).

Files Patch % Lines
cmd/crowdsec-cli/hubtest.go 7.80% 128 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3086      +/-   ##
==========================================
- Coverage   52.56%   52.55%   -0.02%     
==========================================
  Files         281      281              
  Lines       35382    35387       +5     
==========================================
- Hits        18600    18598       -2     
- Misses      14972    14978       +6     
- Partials     1810     1811       +1     
Flag Coverage Δ
bats 40.26% <9.32%> (-0.04%) ⬇️
unit-linux 34.86% <0.00%> (-0.01%) ⬇️
unit-windows 31.01% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc merged commit 2f6d4cc into master Jun 13, 2024
18 checks passed
@mmetc mmetc deleted the cscli-hubtest-run branch June 13, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants