Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix "cscli [machines|bouncers] delete" autocompletion #3101

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jul 1, 2024

No description provided.

Copy link

github-actions bot commented Jul 1, 2024

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

github-actions bot commented Jul 1, 2024

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 23.52941% with 26 lines in your changes missing coverage. Please review.

Project coverage is 51.33%. Comparing base (1acc354) to head (a2f1475).

Files Patch % Lines
cmd/crowdsec-cli/bouncers.go 23.52% 11 Missing and 2 partials ⚠️
cmd/crowdsec-cli/machines.go 23.52% 11 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3101      +/-   ##
==========================================
- Coverage   57.05%   51.33%   -5.72%     
==========================================
  Files         280      292      +12     
  Lines       28602    36448    +7846     
==========================================
+ Hits        16318    18710    +2392     
- Misses      10520    15917    +5397     
- Partials     1764     1821      +57     
Flag Coverage Δ
bats 39.36% <36.36%> (+0.02%) ⬆️
unit-linux 34.69% <0.00%> (-0.03%) ⬇️
unit-windows 30.05% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc merged commit 27935f6 into master Jul 1, 2024
17 checks passed
@mmetc mmetc deleted the autocomplete branch July 1, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants