Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store alert remediations status in DB #3115

Merged
merged 5 commits into from
Jul 16, 2024
Merged

Conversation

blotus
Copy link
Member

@blotus blotus commented Jul 8, 2024

Fixes #2869

Copy link

github-actions bot commented Jul 8, 2024

@blotus: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

github-actions bot commented Jul 8, 2024

@blotus: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@blotus
Copy link
Member Author

blotus commented Jul 8, 2024

/kind fix
/area local-api

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.71%. Comparing base (96a6eec) to head (ddb7370).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3115      +/-   ##
==========================================
- Coverage   49.85%   49.71%   -0.15%     
==========================================
  Files         321      322       +1     
  Lines       37667    37915     +248     
==========================================
+ Hits        18780    18850      +70     
- Misses      17063    17220     +157     
- Partials     1824     1845      +21     
Flag Coverage Δ
bats 38.40% <100.00%> (+0.05%) ⬆️
unit-linux 34.19% <16.66%> (-0.25%) ⬇️
unit-windows 28.87% <50.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LaurenceJJones
Copy link
Contributor

Just note if we can also put this in the output of cscli alerts inspect in the template

@blotus blotus added this to the 1.6.3 milestone Jul 9, 2024
@blotus blotus merged commit c4bfdf1 into master Jul 16, 2024
17 checks passed
@blotus blotus deleted the store-remediation-in-db branch July 16, 2024 08:08
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Alert db model] Remediation type on struct is not held in DB
3 participants