Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove warning "maxopenconns is 0, default to 100" #3129

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jul 12, 2024

also don't store as pointer since value 0 is not useful

@mmetc mmetc added this to the 1.6.3 milestone Jul 12, 2024
@mmetc mmetc requested a review from blotus July 12, 2024 15:26
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 49.71%. Comparing base (f130ce6) to head (59681ee).

Files Patch % Lines
pkg/database/database.go 50.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3129      +/-   ##
==========================================
+ Coverage   49.68%   49.71%   +0.03%     
==========================================
  Files         322      322              
  Lines       37910    37909       -1     
==========================================
+ Hits        18837    18848      +11     
+ Misses      17227    17219       -8     
+ Partials     1846     1842       -4     
Flag Coverage Δ
bats 38.37% <63.63%> (+0.02%) ⬆️
unit-linux 34.17% <100.00%> (+0.01%) ⬆️
unit-windows 28.85% <63.63%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc requested a review from sabban July 15, 2024 08:00
Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

also don't store as pointer since value 0 is not useful
@mmetc mmetc merged commit 5390b8e into master Jul 15, 2024
17 checks passed
@mmetc mmetc deleted the maxopenconns branch July 15, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants