Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cscli/hub: don't return error if some file can't be recognized #3150

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jul 24, 2024

In k8s there can be extra directories while mounting config maps, which leads to a failure while parsing the hub state. The PR changes these kind of errors to warnings.

In k8s there can be extra directories while mounting config maps, which
leads to a failure while parsing the hub state. The PR changes these
kind of errors to warnings.
Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.80%. Comparing base (36d15fe) to head (1149b79).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3150      +/-   ##
==========================================
- Coverage   50.81%   50.80%   -0.02%     
==========================================
  Files         326      326              
  Lines       38579    38580       +1     
==========================================
- Hits        19604    19600       -4     
- Misses      17049    17055       +6     
+ Partials     1926     1925       -1     
Flag Coverage Δ
bats 40.19% <100.00%> (-0.02%) ⬇️
unit-linux 33.97% <0.00%> (-0.01%) ⬇️
unit-windows 28.44% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc merged commit 20067a8 into master Jul 24, 2024
18 checks passed
@mmetc mmetc deleted the cwhub-ignore-unknown-type branch July 24, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants