Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/cwhub: improve support for k8s config maps with custom items #3154

Merged
merged 5 commits into from
Aug 20, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jul 29, 2024

  • allow links to links
  • ignore hidden ..data directories, but allow links to their content
  • allow local items in subdirectories

Todo: think what could go wrong, ex dupes

@mmetc mmetc added the kind/enhancement New feature or request label Jul 29, 2024
@mmetc mmetc added this to the 1.6.3 milestone Jul 29, 2024
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 64.51613% with 44 lines in your changes missing coverage. Please review.

Project coverage is 50.85%. Comparing base (08fdfc4) to head (7aa3482).
Report is 1 commits behind head on master.

Files Patch % Lines
pkg/cwhub/sync.go 66.35% 26 Missing and 10 partials ⚠️
pkg/cwhub/relativepath.go 57.14% 4 Missing and 2 partials ⚠️
pkg/metabase/metabase.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3154      +/-   ##
==========================================
- Coverage   50.86%   50.85%   -0.02%     
==========================================
  Files         325      326       +1     
  Lines       38685    38744      +59     
==========================================
+ Hits        19677    19703      +26     
- Misses      17081    17102      +21     
- Partials     1927     1939      +12     
Flag Coverage Δ
bats 40.28% <70.52%> (+0.04%) ⬆️
unit-linux 34.03% <54.73%> (+0.04%) ⬆️
unit-windows 28.51% <52.41%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc marked this pull request as ready for review July 29, 2024 11:01
@mmetc mmetc modified the milestones: 1.6.3, 1.6.4 Jul 29, 2024
@mmetc mmetc marked this pull request as draft July 29, 2024 12:03
@mmetc mmetc changed the title pkg/cwhub: improve support for k8s config maps as custom items pkg/cwhub: improve support for k8s config maps with custom items Jul 29, 2024
@mmetc mmetc requested a review from buixor July 31, 2024 15:32
@mmetc mmetc force-pushed the cwhub-links-to-links branch 2 times, most recently from 4ed2867 to bf5f570 Compare August 6, 2024 09:16
@mmetc mmetc marked this pull request as ready for review August 6, 2024 09:19
@mmetc mmetc merged commit 3d27e83 into master Aug 20, 2024
17 checks passed
@mmetc mmetc deleted the cwhub-links-to-links branch August 20, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request needs/area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scenario file scanner scans inside Kubernetes configmap mount dirs
2 participants