Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add additional explain options to hubtest #3162

Merged
merged 4 commits into from
Sep 3, 2024

Conversation

LaurenceJJones
Copy link
Contributor

@LaurenceJJones LaurenceJJones commented Aug 2, 2024

Fix #3160

This PR adds additional explain options to hubtest to allow users to benefit from the same options as normal explain.

@LaurenceJJones LaurenceJJones added this to the 1.6.4 milestone Aug 2, 2024
Copy link

github-actions bot commented Aug 2, 2024

@LaurenceJJones: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

github-actions bot commented Aug 2, 2024

@LaurenceJJones: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@LaurenceJJones
Copy link
Contributor Author

/kind enhancement
/area cscli

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 17.50000% with 33 lines in your changes missing coverage. Please review.

Project coverage is 51.09%. Comparing base (f0d6046) to head (5fe2f10).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
cmd/crowdsec-cli/clihubtest/explain.go 17.50% 33 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3162      +/-   ##
==========================================
- Coverage   51.10%   51.09%   -0.02%     
==========================================
  Files         339      339              
  Lines       38710    38729      +19     
==========================================
+ Hits        19784    19788       +4     
- Misses      16982    16995      +13     
- Partials     1944     1946       +2     
Flag Coverage Δ
bats 40.43% <23.33%> (-0.09%) ⬇️
unit-linux 34.66% <0.00%> (-0.02%) ⬇️
unit-windows 28.59% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LaurenceJJones LaurenceJJones merged commit fb0117e into crowdsecurity:master Sep 3, 2024
17 checks passed
@LaurenceJJones LaurenceJJones deleted the hubtest_verbose branch September 3, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cscli kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[hubtest] cscli hubtest explain verbose
2 participants