Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cscli hub update: option --with-content to keep embedded items in index; use it in docker #3195

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Aug 27, 2024

backport to 1.6.3 from #3192

@mmetc mmetc added the kind/enhancement New feature or request label Aug 27, 2024
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc added this to the 1.6.3 milestone Aug 27, 2024
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 57.69231% with 11 lines in your changes missing coverage. Please review.

Project coverage is 50.81%. Comparing base (b754c39) to head (29a7d1e).
Report is 2 commits behind head on releases/1.6.x.

Files Patch % Lines
pkg/cwhub/remote.go 50.00% 7 Missing and 2 partials ⚠️
cmd/crowdsec-cli/hub.go 75.00% 2 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           releases/1.6.x    #3195      +/-   ##
==================================================
+ Coverage           50.79%   50.81%   +0.02%     
==================================================
  Files                 326      326              
  Lines               38680    38704      +24     
==================================================
+ Hits                19647    19667      +20     
+ Misses              17104    17102       -2     
- Partials             1929     1935       +6     
Flag Coverage Δ
bats 40.24% <78.94%> (-0.02%) ⬇️
unit-linux 33.89% <0.00%> (-0.03%) ⬇️
unit-windows 28.38% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc merged commit faa3cd3 into releases/1.6.x Aug 27, 2024
18 checks passed
@mmetc mmetc deleted the cscli-hub-update-with-content-backport branch August 27, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request needs/area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant