Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact cscli - don't export functions if not required #3224

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Sep 11, 2024

No description provided.

@mmetc mmetc added this to the 1.6.4 milestone Sep 11, 2024
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc marked this pull request as ready for review September 11, 2024 11:59
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 86.60714% with 15 lines in your changes missing coverage. Please review.

Project coverage is 51.24%. Comparing base (4d10e9d) to head (f961572).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cmd/crowdsec-cli/clialert/alerts.go 90.69% 2 Missing and 2 partials ⚠️
cmd/crowdsec-cli/clihub/item_metrics.go 66.66% 3 Missing and 1 partial ⚠️
cmd/crowdsec-cli/clihubtest/run.go 55.55% 4 Missing ⚠️
cmd/crowdsec-cli/clihub/items.go 66.66% 0 Missing and 1 partial ⚠️
cmd/crowdsec-cli/clihubtest/explain.go 50.00% 1 Missing ⚠️
cmd/crowdsec-cli/clisetup/setup.go 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3224      +/-   ##
==========================================
- Coverage   51.27%   51.24%   -0.03%     
==========================================
  Files         340      340              
  Lines       38770    38771       +1     
==========================================
- Hits        19878    19869       -9     
- Misses      16936    16945       +9     
- Partials     1956     1957       +1     
Flag Coverage Δ
bats 40.76% <87.38%> (-0.03%) ⬇️
unit-linux 34.66% <0.00%> (+0.01%) ⬆️
unit-windows 28.58% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc requested a review from sabban September 11, 2024 12:21
Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit 57539f6 into master Sep 11, 2024
17 checks passed
@mmetc mmetc deleted the cscli-unexport branch September 11, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants