Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint/revive: check tags on non-exported struct fields #3257

Merged
merged 3 commits into from
Oct 3, 2024
Merged

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Sep 24, 2024

this prevents forgetting to export a tagged field

Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc added this to the 1.6.4 milestone Sep 24, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 51.32%. Comparing base (06adbe0) to head (07dd0e8).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/appsec/appsec_rules_collection.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3257      +/-   ##
==========================================
+ Coverage   51.31%   51.32%   +0.01%     
==========================================
  Files         357      357              
  Lines       38940    38940              
==========================================
+ Hits        19982    19987       +5     
+ Misses      16993    16989       -4     
+ Partials     1965     1964       -1     
Flag Coverage Δ
bats 40.91% <ø> (-0.02%) ⬇️
unit-linux 34.72% <ø> (+<0.01%) ⬆️
unit-windows 28.61% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc marked this pull request as ready for review September 24, 2024 07:33
@mmetc mmetc requested a review from sabban October 2, 2024 14:46
@mmetc mmetc merged commit 4e3495d into master Oct 3, 2024
17 checks passed
@mmetc mmetc deleted the struct-tag branch October 3, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants