-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explicit configuration for signals sharing and blocklists pull #3277
base: master
Are you sure you want to change the base?
Conversation
@blotus: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
@blotus: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
/kind enhancement |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3277 +/- ##
==========================================
+ Coverage 39.27% 42.67% +3.39%
==========================================
Files 480 480
Lines 62217 62455 +238
==========================================
+ Hits 24437 26651 +2214
+ Misses 35124 33150 -1974
+ Partials 2656 2654 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Fixes #3188.
This PR adds 3 new config options:
server.online_client.sharing
: Should crowdsec send alerts to CAPI? Defaults to true.server.online_client.pull.community
: When querying the decision stream in CAPI, should we get the content of the community blocklist ? Defaults to true.server.online_client.pull.blocklists
: When querying the decision stream in CAPI. should we get the content of additional blocklists the instance is subscribed to ? Defaults to true.This goes a bit beyond the scope of the initial issue, but the added granularity is probably worth it (for example, only push signals with no pull when running a honeypot, only pull additional blocklist if you use the console to distribute custom lists,...)