Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact cscli: decisions, lapi, bouncers, machines #3306

Merged
merged 6 commits into from
Oct 30, 2024
Merged

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Oct 29, 2024

No description provided.

@mmetc mmetc added this to the 1.6.4 milestone Oct 29, 2024
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 61.84641% with 467 lines in your changes missing coverage. Please review.

Project coverage is 58.23%. Comparing base (97c1f60) to head (59a5098).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cmd/crowdsec-cli/clilapi/context.go 51.25% 119 Missing and 17 partials ⚠️
cmd/crowdsec-cli/climachine/inspect.go 25.95% 95 Missing and 2 partials ⚠️
cmd/crowdsec-cli/clibouncer/inspect.go 39.39% 38 Missing and 2 partials ⚠️
cmd/crowdsec-cli/climachine/add.go 66.66% 28 Missing and 10 partials ⚠️
cmd/crowdsec-cli/climachine/list.go 56.97% 35 Missing and 2 partials ⚠️
cmd/crowdsec-cli/clibouncer/prune.go 49.15% 28 Missing and 2 partials ⚠️
cmd/crowdsec-cli/climachine/prune.go 59.70% 26 Missing and 1 partial ⚠️
cmd/crowdsec-cli/clibouncer/list.go 67.12% 16 Missing and 8 partials ⚠️
cmd/crowdsec-cli/clilapi/register.go 75.58% 15 Missing and 6 partials ⚠️
cmd/crowdsec-cli/clibouncer/add.go 87.23% 4 Missing and 2 partials ⚠️
... and 4 more
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3306   +/-   ##
=======================================
  Coverage   58.23%   58.23%           
=======================================
  Files         335      349   +14     
  Lines       37397    37377   -20     
=======================================
- Hits        21777    21768    -9     
+ Misses      13724    13718    -6     
+ Partials     1896     1891    -5     
Flag Coverage Δ
bats 41.43% <61.11%> (+0.02%) ⬆️
unit-linux 34.00% <1.06%> (+<0.01%) ⬆️
unit-windows 29.25% <1.06%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc requested a review from sabban October 29, 2024 13:30
Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc changed the title refact "cscli decisions import" refact cscli: decisions, lapi, bouncers, machines Oct 30, 2024
cmd/crowdsec-cli/clilapi/register.go Dismissed Show dismissed Hide dismissed
Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit 92662ed into master Oct 30, 2024
17 checks passed
@mmetc mmetc deleted the decisions-import branch October 30, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants