Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand env var when loading acquis #3375

Merged
merged 3 commits into from
Jan 10, 2025
Merged

expand env var when loading acquis #3375

merged 3 commits into from
Jan 10, 2025

Conversation

blotus
Copy link
Member

@blotus blotus commented Dec 20, 2024

Fixes #3374

@blotus blotus added this to the 1.6.5 milestone Dec 20, 2024
Copy link

@blotus: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@blotus: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@blotus
Copy link
Member Author

blotus commented Dec 20, 2024

/kind enhancement
/area agent

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 58.48%. Comparing base (26c15a1) to head (2dde732).
Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
pkg/acquisition/acquisition.go 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3375   +/-   ##
=======================================
  Coverage   58.48%   58.48%           
=======================================
  Files         352      352           
  Lines       37871    37879    +8     
=======================================
+ Hits        22148    22155    +7     
  Misses      13815    13815           
- Partials     1908     1909    +1     
Flag Coverage Δ
bats 41.32% <66.66%> (+<0.01%) ⬆️
unit-linux 34.45% <66.66%> (+0.01%) ⬆️
unit-windows 29.68% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buixor buixor self-assigned this Dec 20, 2024
@blotus blotus merged commit 34c0e6a into master Jan 10, 2025
17 checks passed
@blotus blotus deleted the expand-env-acquisition branch January 10, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/agent kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support environment variables in acquisition config
3 participants