Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log warning if local items have conflicting names #3399

Merged
merged 5 commits into from
Jan 13, 2025
Merged

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jan 10, 2025

No description provided.

@mmetc mmetc added this to the 1.6.5 milestone Jan 10, 2025
Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc added kind/enhancement New feature or request and removed needs/kind needs/area labels Jan 10, 2025
@mmetc mmetc requested a review from blotus January 10, 2025 15:08
@mmetc mmetc marked this pull request as ready for review January 10, 2025 15:10
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 76.50273% with 43 lines in your changes missing coverage. Please review.

Project coverage is 59.11%. Comparing base (e9c1ed0) to head (55653af).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/cwhub/sync.go 77.52% 25 Missing and 15 partials ⚠️
cmd/crowdsec-cli/dashboard.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3399   +/-   ##
=======================================
  Coverage   59.11%   59.11%           
=======================================
  Files         359      359           
  Lines       38656    38714   +58     
=======================================
+ Hits        22852    22887   +35     
- Misses      13886    13902   +16     
- Partials     1918     1925    +7     
Flag Coverage Δ
bats 42.28% <76.50%> (+0.04%) ⬆️
unit-linux 32.76% <2.73%> (-0.05%) ⬇️
unit-windows 28.14% <2.77%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc merged commit 5df5684 into master Jan 13, 2025
18 checks passed
@mmetc mmetc deleted the hub-samename branch January 13, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/agent kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants