Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: enable errcheck; add allowlist and explicit checks #3403

Merged
merged 5 commits into from
Jan 16, 2025
Merged

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jan 16, 2025

No description provided.

@mmetc mmetc added this to the 1.6.5 milestone Jan 16, 2025
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 30.23256% with 30 lines in your changes missing coverage. Please review.

Project coverage is 59.33%. Comparing base (fe931af) to head (c7dd66d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/acquisition/modules/appsec/appsec.go 0.00% 4 Missing ⚠️
pkg/cticlient/example/fire.go 0.00% 4 Missing ⚠️
pkg/parser/stage.go 0.00% 4 Missing ⚠️
cmd/crowdsec-cli/climachine/add.go 40.00% 3 Missing ⚠️
...g/acquisition/modules/kubernetesaudit/k8s_audit.go 0.00% 2 Missing and 1 partial ⚠️
pkg/exprhelpers/helpers.go 66.66% 2 Missing and 1 partial ⚠️
pkg/leakybucket/manager_load.go 0.00% 3 Missing ⚠️
pkg/parser/node.go 0.00% 2 Missing and 1 partial ⚠️
pkg/setup/install.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3403      +/-   ##
==========================================
- Coverage   59.33%   59.33%   -0.01%     
==========================================
  Files         358      358              
  Lines       38398    38411      +13     
==========================================
+ Hits        22785    22792       +7     
- Misses      13723    13729       +6     
  Partials     1890     1890              
Flag Coverage Δ
bats 42.25% <17.94%> (+0.01%) ⬆️
unit-linux 33.18% <13.95%> (-0.02%) ⬇️
unit-windows 28.46% <13.95%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc merged commit 49fb24c into master Jan 16, 2025
17 checks passed
@mmetc mmetc deleted the lint-errcheck branch January 16, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants