Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Log appsec error on writing response to remediation #3412

Merged

Conversation

LaurenceJJones
Copy link
Contributor

@LaurenceJJones LaurenceJJones commented Jan 17, 2025

To aid debugging lua-cs-bouncer issues, we should also log the error if it is generated from trying to write a response to the remediation as the previous log can be seen as it managed to write but we dont know if it did or didnt 🤷🏻

crowdsecurity/lua-cs-bouncer#77

Copy link

@LaurenceJJones: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@LaurenceJJones: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@LaurenceJJones
Copy link
Contributor Author

/kind enhancement
/area appsec

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 59.32%. Comparing base (49fb24c) to head (366dc05).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/acquisition/modules/appsec/appsec.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3412      +/-   ##
==========================================
+ Coverage   59.30%   59.32%   +0.02%     
==========================================
  Files         358      346      -12     
  Lines       38411    37543     -868     
==========================================
- Hits        22779    22273     -506     
+ Misses      13739    13439     -300     
+ Partials     1893     1831      -62     
Flag Coverage Δ
bats 42.25% <0.00%> (+0.05%) ⬆️
unit-linux 33.18% <0.00%> (+0.01%) ⬆️
unit-windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LaurenceJJones LaurenceJJones merged commit 7d12b80 into crowdsecurity:master Jan 18, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/appsec kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants