Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/cticlient: Add missing field in SmokeItem and FireItem #3413

Merged
merged 4 commits into from
Jan 20, 2025

Conversation

AlteredCoder
Copy link
Contributor

No description provided.

Copy link

@AlteredCoder: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@AlteredCoder: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@AlteredCoder
Copy link
Contributor Author

/kind fix

@AlteredCoder
Copy link
Contributor Author

/area agent

Copy link

codecov bot commented Jan 19, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 59.32%. Comparing base (7d12b80) to head (19a80cf).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
pkg/cticlient/types.go 50.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3413      +/-   ##
==========================================
+ Coverage   59.30%   59.32%   +0.01%     
==========================================
  Files         358      358              
  Lines       38412    38428      +16     
==========================================
+ Hits        22781    22797      +16     
- Misses      13738    13740       +2     
+ Partials     1893     1891       -2     
Flag Coverage Δ
bats 42.23% <0.00%> (-0.02%) ⬇️
unit-linux 33.19% <50.00%> (+0.02%) ⬆️
unit-windows 28.47% <50.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlteredCoder AlteredCoder changed the title pkg/cticlient: Add missing field in SmokeItem pkg/cticlient: Add missing field in SmokeItem and FireItem Jan 20, 2025
@AlteredCoder AlteredCoder merged commit d6b3841 into master Jan 20, 2025
17 checks passed
@AlteredCoder AlteredCoder deleted the cticlient_add_missing_smoke_item branch January 20, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants