Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cscli: cliconfig - refactor / remove global variables and gratuitous pointer #3414

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jan 20, 2025

No description provided.

@mmetc mmetc added this to the 1.6.5 milestone Jan 20, 2025
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc marked this pull request as draft January 20, 2025 08:32
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.30%. Comparing base (49fb24c) to head (2eb1099).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3414   +/-   ##
=======================================
  Coverage   59.30%   59.30%           
=======================================
  Files         358      358           
  Lines       38411    38412    +1     
=======================================
+ Hits        22779    22782    +3     
+ Misses      13739    13737    -2     
  Partials     1893     1893           
Flag Coverage Δ
bats 42.22% <100.00%> (+0.02%) ⬆️
unit-linux 33.16% <23.07%> (-0.01%) ⬇️
unit-windows 28.46% <23.07%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc marked this pull request as ready for review January 20, 2025 09:00
Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit bd7e1b5 into master Jan 20, 2025
17 checks passed
@mmetc mmetc deleted the cscli-config branch January 20, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants