deb packaging: prevent installing crowdsec.service twice #3415
Conversation
… to /usr/lib We don't need to explicitly copy the file, but the standard location is /usr/lib, not /lib - hence we duplicate it by copying explicitly if /lib is not linked to /usr/lib. Also we don't need preinst anymore and the message is in postinst as well.
|
@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
|
@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3415 +/- ##
==========================================
- Coverage 59.33% 59.30% -0.03%
==========================================
Files 358 358
Lines 38412 38428 +16
==========================================
Hits 22791 22791
- Misses 13730 13745 +15
- Partials 1891 1892 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
We don't need to explicitly copy the crowdsec.service file, but the standard location is /usr/lib, not /lib - hence we duplicate it by copying explicitly if /lib is not linked to /usr/lib.
Also we don't need preinst anymore and the message is in postinst as well.