Fix naming inconsistency #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While distribution packages are probably going to use an explicit name like crowdsec-custom-bouncer, it makes sense to have the Go import path match the location of the Git repository (as that's already done for cs-firewall-bouncer).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While distribution packages are probably going to use an explicit name like crowdsec-custom-bouncer, it makes sense to have the Go import path match the location of the Git repository (as that's already done for cs-firewall-bouncer).
Note: This is definitely not a blocker packaging-wise (I already have a local patch anyway), I just have to make sure the
Go-Import-Pathdeclared indebian/controlmatches the declared module name to ensure the build is fine. I could do the opposite, and docs-→crowdsec-in theGo-Import-Path, whatever works for you is fine with me.