Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove join fetches from entity find query #213

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

agrancaric
Copy link
Collaborator

@agrancaric agrancaric commented Jul 1, 2024

Basic information

  • nrich version:
    2.5.1
  • Module:
    nrich-registry

Additional information

Description

Summary

Removed join fetches from the entity find query since it causes issues with multiple associations and is unnecessary for the query.

Details

Removed join fetches from the entity find query since it causes issues with multiple associations and is unnecessary for the query.

Related issue

Types of changes

  • Enhancement (non-breaking change which enhances existing functionality)

Checklist

  • I have read the project's CONTRIBUTING document
  • I have checked my code with the project's static analysis tooling
  • I have formatted my code with the project's IDEA code-style configuration
  • I have checked my code for misspellings
  • I have organized my changes in easy-to-follow commits
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests pass.

…h multiple associations and it is not needed for query
@agrancaric agrancaric requested a review from jzrilic July 1, 2024 08:16
@agrancaric agrancaric self-assigned this Jul 1, 2024
@jzrilic jzrilic changed the title Remove join fetches from entity find query since it causes issues wit… Remove join fetches from entity find query Jul 1, 2024
@jzrilic jzrilic merged commit ac7e877 into master Jul 1, 2024
6 checks passed
@jzrilic jzrilic deleted the feature_removdJoinFetchFromFindAlias branch July 1, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants