Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tackles major and minor issues in the package. I'm sorry for not splitting it into separate pull requests; the problems were related.
Description
This pull request addresses the following issues:
var(2 * sum(E_i))
instead ofvar(sum(E_i))
assuming Poisson statistics. I also found this factor in the old Excel sheet; however, it lacks justification. Suppose it is intended as an additional overdispersion value. In that case, it should appear outside, not inside, and better be addressed with the (already existing)epsilon
parameter. Given that this was unexpected, I've updated the documentation for the current calculation.predict_dose()
is calleduse_MC
and is set toFALSE
by default so as not to break the old code.Signal ...
, I changed itIntegrated signal ...
rendering more straightforward to understand. This changed required an update of the plot output snapshotsRelated Issue
Not applicable
Example
Output
use_MC = FALSE
(default)Output
use_MC = TRUE
(new)This output depends slightly on the set random seed.