fix: RO-Crate validation should work for nested properties without id

fixes issue #27
crs4 · Nov 12, 2024 · e38e724 · e38e724
1 parent bcbe829
commit e38e724
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 19 deletions.
diff --git a/rocrate_validator/profiles/ro-crate/must/0_file_descriptor_format.py b/rocrate_validator/profiles/ro-crate/must/0_file_descriptor_format.py
@@ -97,7 +97,6 @@ def check_context(self, context: ValidationContext) -> bool:
     @check(name="File Descriptor JSON-LD must be flattened")
     def check_flattened(self, context: ValidationContext) -> bool:
         """ Check if the file descriptor is flattened """
-
         def is_entity_flat_recursive(entity: Any, is_first: bool = True) -> bool:
             """ Recursively check if the given data corresponds to a flattened JSON-LD object
             and returns False if it does not and is not a root element
@@ -109,7 +108,7 @@ def is_entity_flat_recursive(entity: Any, is_first: bool = True) -> bool:
                             return False
                 # if this is not the root element, it must not contain more properties than @id
                 else:
-                    if "@id" in entity and len(entity) > 1:
+                    if "@id" not in entity or len(entity) > 1:
                         return False
             if isinstance(entity, list):
                 for element in entity:

diff --git a/...valid/0_file_descriptor_format/invalid_jsonld_format/not_flattened/ro-crate-metadata.json b/...valid/0_file_descriptor_format/invalid_jsonld_format/not_flattened/ro-crate-metadata.json
@@ -8,24 +8,24 @@
                 "@id": "https://w3id.org/ro/crate/1.1"
             },
             "about": {
-                "@type": "Dataset",
-                "@id": "./",
-                "hasPart": [
-                    {
-                        "@type": "File",
-                        "@id": "test.csv",
-                        "encodingFormat": "text/csv",
-                        "name": "This is a test file",
-                        "description": "This is a test dataset"
-                    }
-                ],
-                "name": "This is a test dataset",
-                "description": "This is a test dataset",
-                "license": {
-                    "@id": "https://creativecommons.org/licenses/by/4.0/"
-                },
-                "datePublished": "2024-11-05"
+                "@id": "./"
             }
+        },
+        {
+            "@id": "./",
+            "@type": "Dataset",
+            "name": "This is a test dataset",
+            "description": "This is a test dataset",
+            "license": {
+                "@id": "https://creativecommons.org/licenses/by/4.0/"
+            },
+            "datePublished": "2024-11-05",
+            "hasPart": [
+                {
+                    "@type": "File",
+                    "name": "File in a nested entity"
+                }
+            ]
         }
     ]
 }