Merge branch '2.3-fix'

crscheid · Jul 21, 2021 · 795851c · 795851c
2 parents 9a62f72 + c1bca51
commit 795851c
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/README.md b/README.md
@@ -158,7 +158,7 @@ Unit tests are included in this distribution and can be run utilizing PHPUnit af
 This will use the composer docker image to download the requirements. Note the use of the `--ignore-platform-reqs` since some of our dependencies do not yet support PHP 8.
 
 ```
- docker run --rm --interactive --tty --volume $PWD:/app composer --ignore-platform-reqs install
+docker run --rm --interactive --tty --volume $PWD:/app composer --ignore-platform-reqs install
 ```
 
 ### Running Unit Tests

diff --git a/src/ArticleExtractor.php b/src/ArticleExtractor.php
@@ -280,6 +280,7 @@ private function parseURLViaReadability($url) {
     $text = null;
     $title = null;
 		$method = "readability";
+		$html = null;
 
     try {
 			if($this->user_agent != null) {

diff --git a/tests/ExtractorTest.php b/tests/ExtractorTest.php
@@ -6,6 +6,7 @@
 class ExtractorTest extends TestCase {
 
 	private $problem_sites = [
+		'https://news.google.com/__i/rss/rd/articles/CBMihgFodHRwczovL29oaW9jYXBpdGFsam91cm5hbC5jb20vMjAyMS8wNy8yMS9zdHVkeS1jZW50cmFsLW9oaW8taG91c2luZy1zdGFiaWxpemF0aW9uLXByb2plY3QtaW1wcm92ZWQtaGVhbHRoLW91dGNvbWVzLWZvci13b21lbi1pbmZhbnRzL9IBAA?oc=5',
 		'https://www.google.com/url?rct=j&sa=t&url=https://medium.com/pcmag-access/majority-of-iot-traffic-on-corporate-networks-is-insecure-report-finds-fca274d7409a%3Fsource%3Dtopic_page---------0------------------1&ct=ga&cd=CAIyGjUwNDYzZmZmOTBiY2RhNTM6Y29tOmVuOlVT&usg=AFQjCNHdAURGnK0sMRnSgOckblLTRgxUAQ',
 		'https://slashdot.org/story/18/07/19/2050244/microsofts-plan-to-try-to-win-back-consumers-with-modern-life-services',
 		'http://feedproxy.google.com/~r/businessinsider/~3/EChmgXESt_4/wells-fargo-close-settlement-end-probes-sales-practices-federal-prosecutors-2020-2-1028927535', // Issue #26 multiple redirects occur when browser user-agent not set