Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load strings from external file instead of using hard coded values #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NurMarvin
Copy link
Contributor

@NurMarvin NurMarvin commented Oct 22, 2019

I've extracted the most important strings from all files and put them into the lang/en_US.json file.
There are two strings that are important and weren't extracted because I was unable to extract without breaking the sites functionality.
This is due to them having links in them that I would have had to either include in the translation file, which could cause breaks over time through e.g. method or URL changes or alternatively make multiple strings that only include the text parts, leaving the links out.
There probably also is a third way more elegant way of doing this, but I was unable to get something like that to work with my limited Vue.js knowledge.
There are also some other "hacky" ways I used for other translations that can probably be done more elegant.
This is only the first step to localization, I might implement the language switching mechanism too at some point, but I wouldn't mind if someone else did.

Closes #45

@NurMarvin
Copy link
Contributor Author

Oh and I also separated some previously united things, e.g. the creating and starting messages in the video player, to make it easier for translators to make individual translations where necessary.

@NurMarvin
Copy link
Contributor Author

Another thing, I missed some messages because I got quite sleepy over the course of making this and now I'm too sleepy to finish it, so would appreciate if someone else could do it once this is merged.

@darnfish darnfish self-requested a review October 23, 2019 00:21
@darnfish darnfish added the enhancement New feature or request label Oct 23, 2019
@darnfish
Copy link
Contributor

This looks really good! I'll run a couple tests locally and then I'll merge this in if you're ready.

@JeDaYoshi
Copy link
Member

I will do some changes before merging it in.

@JeDaYoshi
Copy link
Member

#77 needs to be done before giving attention to this, to ensure it can be correctly translated.

Also that due to linting changes, conflicts should be resolved now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Localisation
3 participants