build(cel): force override protobuf transitive dep used by CEL #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-triage
andrewazores
added
build
chore
andrewazores
force-pushed
the
downgrade-protobuf
branch
from
c2c8218
to
77f6204
Compare
ebaron
previously approved these changes
Nov 24, 2023
andrewazores
dismissed
ebaron’s stale review
The merge-base changed after approval.
andrewazores
force-pushed
the
downgrade-protobuf
branch
from
77f6204
to
525e182
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #261
Related to #258
Depends on #258
I tried a quick manual test of this by setting up the Cryostat
smoketest.shto put a Smart Trigger onquarkus-test-agent-1as usual, after rebuilding it with this updated Agent JAR. The trigger was successfully activated, so it looks like CEL is working with the downgraded protobuf at least for the code paths that we currently exercise.